A path traversal vulnerability exists in GuardDog's safe_extract() function that allows malicious PyPI packages to write arbitrary files outside the intended extraction directory, leading to Arbitrary File Overwrite and Remote Code Execution on systems running GuardDog.
CWE: CWE-22 (Improper Limitation of a Pathname to a Restricted Directory)
File: guarddog/utils/archives.py
elif zipfile.is_zipfile(source_archive):
with zipfile.ZipFile(source_archive, "r") as zip:
for file in zip.namelist():
# Note: zip.extract cleans up any malicious file name
# such as directory traversal attempts This is not the
# case of zipfile.extractall
zip.extract(file, path=os.path.join(target_directory, file)) # ❌ VULNERABLE
The comment about zip.extract() fooled me at first :) then I noticed the os.path.join() call.
The vulnerability stems from incorrect usage of Python's zipfile.ZipFile.extract() API:
path parameter should be the target directory, not a full file pathextract() automatically appends the member name to the pathos.path.join(target_directory, file), GuardDog causes the filename to be appended twiceguarddog pypi scan malicious-pkgImpact depends on how GuardDog is running and under which environment.
Immediate Code Execution
~/.bashrc → executes on next shell~/.profile → executes on loginPersistent Backdoors
0.1.10.1.100.1.30.1.40.1.50.1.60.1.70.1.80.1.91.0.0+45 more2.7.1Exploitability
AV:NAC:LAT:NPR:NUI:PVulnerable System
VC:HVI:HVA:HSubsequent System
SC:NSI:NSA:NCVSS:4.0/AV:N/AC:L/AT:N/PR:N/UI:P/VC:H/VI:H/VA:H/SC:N/SI:N/SA:N