Missing authorization in the update_folder action: any authenticated non-read-only user can rename, re-parent and convert to personal any folder in the instance, moving another team's credential subtree into their own personal space and removing it from the organization. Confirmed at HEAD 2f271cdd (3.2.1.1), and present at 3.1.3.1 and 3.1.7.6.
The folder-management endpoint dispatches an update_folder action that renames and re-parents a folder. Unlike its sibling actions in the same file, it never checks the edited folder id or the submitted parent id against the caller's accessible-folder set, and the file itself performs no session/authorization gate at all. By pointing the new parent at their own personal folder, an authenticated low-privilege user takes ownership of any folder in the instance.
app/sources/folders.queries.php:
(int) $isPersonal === 1.So update_folder is the one folder-mutating action in the file without an authorization predicate on either the target folder id or the new parent id.
An authenticated TeamPass user who is not read-only (no administrative role required). The attacker submits update_folder with the victim folder's id and a parentId pointing at their own personal folder. Because the new parent is personal, the personal-folder computation sets $isPersonal = 1, which satisfies the line 503...
3.2.2.0Exploitability
AV:NAC:LPR:LUI:NScope
S:UImpact
C:LI:HA:H8.3/CVSS:3.1/AV:N/AC:L/PR:L/UI:N/S:U/C:L/I:H/A:HAccess Control
Other